Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): diffrent sorting methods of project list #2006

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Mar 23, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #2006 (3154967) into main (7c66016) will decrease coverage by 8.55%.
The diff coverage is 70.27%.

@@             Coverage Diff              @@
##               main    #2006      +/-   ##
============================================
- Coverage     82.15%   73.61%   -8.55%     
- Complexity     2219     2235      +16     
============================================
  Files           409      312      -97     
  Lines         21597    10739   -10858     
  Branches       1207     1212       +5     
============================================
- Hits          17744     7906    -9838     
+ Misses         3306     2283    -1023     
- Partials        547      550       +3     
Flag Coverage Δ
controller 73.61% <70.27%> (+0.04%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../configuration/security/SecurityConfiguration.java 0.00% <ø> (ø)
...starwhale/mlops/domain/project/ProjectService.java 71.35% <35.71%> (-5.31%) ⬇️
...ai/starwhale/mlops/domain/job/storage/JobRepo.java 71.28% <50.00%> (ø)
...ale/mlops/domain/project/mapper/ProjectMapper.java 56.25% <72.72%> (+4.89%) ⬆️
...java/ai/starwhale/mlops/api/ProjectController.java 85.71% <100.00%> (-0.96%) ⬇️
...tarwhale/mlops/domain/project/sort/LatestSort.java 100.00% <100.00%> (ø)
...tarwhale/mlops/domain/project/sort/OldestSort.java 100.00% <100.00%> (ø)
...mlops/domain/project/sort/RecentlyVisitedSort.java 100.00% <100.00%> (ø)

... and 102 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreamlandliu dreamlandliu merged commit d6eb6e3 into star-whale:main Mar 29, 2023
@dreamlandliu dreamlandliu deleted the feat/project_sort_ut branch March 29, 2023 03:44
dreamlandliu added a commit to dreamlandliu/starwhale that referenced this pull request Mar 29, 2023
…e#2006)

* feat: different sorting methods of projects

* unit test

* move project visited to get project info api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants