-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(controller): add object storage for dataset #1993
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1993 +/- ##
============================================
- Coverage 82.21% 82.09% -0.13%
- Complexity 2220 2226 +6
============================================
Files 410 412 +2
Lines 21586 21612 +26
Branches 1207 1211 +4
============================================
- Hits 17748 17742 -6
- Misses 3291 3322 +31
- Partials 547 548 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
AS-IS:
AFTER THIS PR:
Why:
The meta info in the same dataset with different versions are save in one datastore table after dataset versioning is done. The file storage of the same dataset with different versions should also has the same storage location in case of tiny change among versions.
Side effect
4 APIs are added:
2 APIs are deleted:
Verification
TODO
return absolute path when after saving hashed blob
Modules
Checklist