Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): eval pages works with project name in uri #1991

Merged
merged 1 commit into from
Mar 24, 2023
Merged

fix(console): eval pages works with project name in uri #1991

merged 1 commit into from
Mar 24, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Mar 22, 2023 •
edited
Loading

Description

listTables can not works with project name, fix it

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added bug 🐛 Something isn't working console 🎨 console labels Mar 22, 2023
@jialeicui jialeicui requested a review from waynelwz March 22, 2023 06:51
waynelwz
waynelwz approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynelwz waynelwz merged commit 1814201 into star-whale:main Mar 24, 2023
@jialeicui jialeicui deleted the eval-console branch March 24, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynelwz waynelwz waynelwz approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something isn't working console 🎨 console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jialeicui @waynelwz