Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): cli supports displaying eval on locally served web pages #1949

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Mar 13, 2023

Description

  • Support showing eval detail via the web browser
  • Support saving the panel layout setting to the workdir/.starwhale/panel.json (mp build cmd will use this file)
  • Hide all the sidebar and header in the web page
panel.mp4

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1949 (5ecdf72) into main (5485203) will increase coverage by 8.48%.
The diff coverage is 90.28%.

@@             Coverage Diff              @@
##               main    #1949      +/-   ##
============================================
+ Coverage     82.45%   90.93%   +8.48%     
============================================
  Files           379       96     -283     
  Lines         20506    10651    -9855     
  Branches       1121        0    -1121     
============================================
- Hits          16908     9686    -7222     
+ Misses         3087      965    -2122     
+ Partials        511        0     -511     
Flag Coverage Δ
controller ?
standalone 90.93% <90.28%> (-0.02%) ⬇️
unittests 90.93% <90.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/eval/view.py 67.35% <25.00%> (-3.13%) ⬇️
client/starwhale/web/server.py 94.73% <94.73%> (ø)
client/starwhale/web/data_store.py 95.16% <95.16%> (ø)
client/starwhale/api/_impl/data_store.py 95.31% <100.00%> (ø)
client/starwhale/web/panel.py 100.00% <100.00%> (ø)
client/starwhale/web/project.py 100.00% <100.00%> (ø)
client/starwhale/web/response.py 100.00% <100.00%> (ø)
client/starwhale/web/system.py 100.00% <100.00%> (ø)
client/starwhale/web/user.py 100.00% <100.00%> (ø)

... and 290 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut
Copy link
Member

@jialeicui does the released python package include console js files?

@tianweidut
Copy link
Member

Others LGTM

waynelwz
waynelwz previously approved these changes Mar 14, 2023
Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui
Copy link
Contributor Author

@jialeicui does the released python package include console js files?

Yes, you're right 👍
I will make another PR to do this
@tianweidut

@tianweidut tianweidut merged commit 1b77c8b into star-whale:main Mar 15, 2023
@jialeicui jialeicui deleted the eval-info-web branch March 15, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants