Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): update model_version.manifest to mediumtext #1935

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

jialeicui
Copy link
Contributor

Description

update model_version.manifest to mediumtext

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #1935 (faba9d8) into main (a5ba229) will decrease coverage by 8.86%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1935      +/-   ##
============================================
- Coverage     82.40%   73.55%   -8.86%     
+ Complexity     2065     2064       -1     
============================================
  Files           376      289      -87     
  Lines         20432     9999   -10433     
  Branches       1121     1121              
============================================
- Hits          16838     7355    -9483     
+ Misses         3084     2134     -950     
  Partials        510      510              
Flag Coverage Δ
controller 73.55% <ø> (+0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tarwhale/mlops/datastore/impl/MemoryTableImpl.java 90.05% <0.00%> (-0.29%) ⬇️
client/starwhale/core/instance/view.py
client/starwhale/utils/progress.py
...lient/starwhale/integrations/tensorflow/dataset.py
client/starwhale/base/uricomponents/exceptions.py
client/starwhale/api/_impl/track/base.py
client/starwhale/api/_impl/wrapper.py
client/starwhale/api/_impl/dataset/model.py
client/starwhale/integrations/pytorch/dataset.py
client/starwhale/api/_impl/service.py
... and 79 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 3a61520 into star-whale:main Mar 9, 2023
@jialeicui jialeicui deleted the db-migration branch March 9, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants