Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): show content directly in TextViewer #1930

Merged
merged 1 commit into from
Mar 8, 2023
Merged

fix(console): show content directly in TextViewer #1930

merged 1 commit into from
Mar 8, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Mar 8, 2023 •
edited
Loading

Description

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added bug 🐛 Something isn't working console 🎨 console labels Mar 8, 2023
waynelwz
waynelwz approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynelwz waynelwz merged commit 2e4f870 into star-whale:main Mar 8, 2023
@jialeicui jialeicui deleted the fix-dataset-text-viewer branch March 8, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynelwz waynelwz waynelwz approved these changes

@anda-ren anda-ren Awaiting requested review from anda-ren

Assignees
No one assigned
Labels
bug 🐛 Something isn't working console 🎨 console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jialeicui @waynelwz