Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): fix server build issue in e2e #1927

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix(e2e): fix server build issue in e2e #1927

merged 1 commit into from
Mar 7, 2023

Conversation

jialeicui
Copy link
Contributor

Description

The buildx can not support build to local image atm, add build-server-for-local-usage target for e2e usage

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

goldenxinxing
goldenxinxing approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 67dad2f into star-whale:main Mar 7, 2023
@jialeicui jialeicui deleted the fix-e2e-build branch March 8, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldenxinxing goldenxinxing goldenxinxing approved these changes

@anda-ren anda-ren Awaiting requested review from anda-ren

Assignees
No one assigned
Labels
chore 🛎️ some tiny change docker 🗃️ e2e-test-case
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jialeicui @goldenxinxing