Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): explicitlly set charset of offline log #1880

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

anda-ren
Copy link
Member

Description

explicitlly set charset of offline log
image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #1880 (ff4280a) into main (b2e0af5) will decrease coverage by 8.41%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1880      +/-   ##
============================================
- Coverage     82.65%   74.25%   -8.41%     
- Complexity     2017     2024       +7     
============================================
  Files           373      287      -86     
  Lines         19978     9672   -10306     
  Branches       1070     1072       +2     
============================================
- Hits          16513     7182    -9331     
+ Misses         2999     2023     -976     
- Partials        466      467       +1     
Flag Coverage Δ
controller 74.25% <0.00%> (+0.24%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/ai/starwhale/mlops/domain/task/TaskService.java 41.93% <0.00%> (ø)
...n/java/ai/starwhale/mlops/domain/user/bo/Role.java 33.33% <0.00%> (ø)
client/starwhale/api/_impl/track/base.py
client/starwhale/core/project/model.py
client/starwhale/api/model.py
client/starwhale/core/job/model.py
client/starwhale/api/_impl/track/handler.py
client/starwhale/consts/__init__.py
...ient/starwhale/integrations/tensorflow/__init__.py
client/starwhale/utils/fs.py
... and 85 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 9e00851 into star-whale:main Feb 22, 2023
@anda-ren anda-ren deleted the charset branch April 10, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants