Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): add a temp flag to keep the first archived versions dir #1869

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

tianweidut
Copy link
Member

Description

when the pr is merged, we could delete the keep_files flag.

Modules

  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added doc 📄 Improvements or additions to documentation chore 🛎️ some tiny change labels Feb 21, 2023
@tianweidut tianweidut self-assigned this Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #1869 (8b42f0c) into main (06ba63e) will increase coverage by 8.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1869      +/-   ##
============================================
+ Coverage     82.10%   90.15%   +8.04%     
============================================
  Files           366       79     -287     
  Lines         19355     9696    -9659     
  Branches       1070        0    -1070     
============================================
- Hits          15892     8741    -7151     
+ Misses         2998      955    -2043     
+ Partials        465        0     -465     
Flag Coverage Δ
controller ?
standalone 90.15% <ø> (ø)
unittests 90.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hale/mlops/domain/bundle/revert/RevertManager.java
...ops/domain/job/mapper/JobDatasetVersionMapper.java
.../ai/starwhale/mlops/datastore/ColumnTypeTuple.java
...whale/mlops/api/protocol/upload/UploadRequest.java
...hale/mlops/api/protocol/runtime/RuntimeInfoVo.java
...in/java/ai/starwhale/mlops/storage/StorageUri.java
...rwhale/mlops/domain/dataset/bo/DatasetVersion.java
...e/mlops/datastore/exporter/RecordsExporterCsv.java
...i/starwhale/mlops/domain/model/po/ModelEntity.java
...java/ai/starwhale/mlops/api/ProjectController.java
... and 277 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 761e728 into star-whale:main Feb 23, 2023
@tianweidut tianweidut deleted the fix/config2 branch April 14, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change doc 📄 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants