Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(controller): refactor of service & dao reference and fix bugs #1856

Merged
merged 7 commits into from
Feb 20, 2023

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Feb 17, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1856 (26b03fc) into main (2ca9ba0) will decrease coverage by 8.20%.
The diff coverage is 81.94%.

@@             Coverage Diff              @@
##               main    #1856      +/-   ##
============================================
- Coverage     82.19%   74.00%   -8.20%     
- Complexity     2009     2015       +6     
============================================
  Files           360      287      -73     
  Lines         19269     9664    -9605     
  Branches       1067     1068       +1     
============================================
- Hits          15839     7152    -8687     
+ Misses         2973     2049     -924     
- Partials        457      463       +6     
Flag Coverage Δ
controller 74.00% <81.94%> (-0.12%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...whale/mlops/api/protocol/user/ProjectMemberVo.java 0.00% <0.00%> (ø)
...a/ai/starwhale/mlops/api/protocol/user/RoleVo.java 40.00% <0.00%> (-60.00%) ⬇️
.../configuration/security/SecurityConfiguration.java 0.00% <0.00%> (ø)
...ain/java/ai/starwhale/mlops/domain/job/JobDao.java 16.17% <ø> (+0.68%) ⬆️
...va/ai/starwhale/mlops/domain/task/TaskService.java 41.93% <ø> (+0.75%) ⬆️
...e/mlops/configuration/security/JwtTokenFilter.java 28.57% <25.00%> (+1.07%) ⬆️
...starwhale/mlops/domain/project/ProjectService.java 74.85% <66.66%> (-5.56%) ⬇️
...tarwhale/mlops/api/protocol/project/ProjectVo.java 58.62% <69.23%> (-16.38%) ⬇️
...ai/starwhale/mlops/domain/job/storage/JobRepo.java 71.28% <75.00%> (ø)
.../ai/starwhale/mlops/domain/trash/TrashService.java 81.57% <77.77%> (+2.09%) ⬆️
... and 105 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 3b39884 into star-whale:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants