Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): do not wait for stdin so that the remote side can stop immediately when the command quits #1844

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Feb 16, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1844 (c995770) into main (eae7b33) will increase coverage by 8.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1844      +/-   ##
============================================
+ Coverage     82.09%   90.21%   +8.11%     
============================================
  Files           360       79     -281     
  Lines         19248     9643    -9605     
  Branches       1067        0    -1067     
============================================
- Hits          15801     8699    -7102     
+ Misses         2996      944    -2052     
+ Partials        451        0     -451     
Flag Coverage Δ
controller ?
standalone 90.21% <ø> (ø)
unittests 90.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/ai/starwhale/mlops/datastore/ColumnTypeMap.java
...ale/mlops/domain/dataset/mapper/DatasetMapper.java
...lops/datastore/parquet/SwParquetWriterBuilder.java
...aset/index/datastore/DataStoreTableNameHelper.java
...i/starwhale/mlops/domain/job/status/JobStatus.java
...le/mlops/domain/dataset/dataloader/DataLoader.java
...tarwhale/mlops/api/protocol/model/ModelInfoVo.java
...i/starwhale/mlops/configuration/DockerSetting.java
...n/java/ai/starwhale/mlops/common/util/Md5Util.java
...ava/ai/starwhale/mlops/reporting/ReportedTask.java
... and 271 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut merged commit 11d90db into star-whale:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants