Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example): refactor example makefile for the seperated prepare phases #1841

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.4.0 milestone Feb 15, 2023
@tianweidut tianweidut self-assigned this Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #1841 (f8239fb) into main (5555804) will increase coverage by 8.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1841      +/-   ##
============================================
+ Coverage     82.08%   90.21%   +8.12%     
============================================
  Files           360       79     -281     
  Lines         19248     9643    -9605     
  Branches       1067        0    -1067     
============================================
- Hits          15799     8699    -7100     
+ Misses         2997      944    -2053     
+ Partials        452        0     -452     
Flag Coverage Δ
controller ?
standalone 90.21% <ø> (ø)
unittests 90.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/dataset/dataloader/mapper/DataReadLogMapper.java
...n/CompatibleStorageAccessServiceBuilderAliyun.java
.../mlops/domain/dataset/po/DatasetVersionEntity.java
...starwhale/mlops/domain/bundle/BundleException.java
.../starwhale/mlops/storage/NopCloserInputStream.java
.../ai/starwhale/mlops/domain/model/ModelService.java
.../configuration/security/SecurityConfiguration.java
...tarwhale/mlops/domain/job/cache/HotJobsLoader.java
...starwhale/mlops/domain/storage/StorageService.java
...in/java/ai/starwhale/mlops/common/OrderParams.java
... and 271 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit eae7b33 into star-whale:main Feb 16, 2023
@tianweidut tianweidut deleted the chore/update-example-makefile branch April 16, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants