Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): improve ut stability by prolonging the time gap #1835

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Feb 14, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #1835 (b22a76d) into main (00218e8) will increase coverage by 8.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1835      +/-   ##
============================================
+ Coverage     82.10%   90.22%   +8.11%     
============================================
  Files           359       79     -280     
  Lines         19131     9591    -9540     
  Branches       1060        0    -1060     
============================================
- Hits          15707     8653    -7054     
+ Misses         2979      938    -2041     
+ Partials        445        0     -445     
Flag Coverage Δ
controller ?
standalone 90.22% <ø> (ø)
unittests 90.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rwhale/mlops/domain/dataset/bo/DatasetVersion.java
...arwhale/mlops/configuration/RunTimeProperties.java
...arwhale/mlops/domain/dataset/po/DatasetEntity.java
...arwhale/mlops/domain/model/mapper/ModelMapper.java
...a/ai/starwhale/mlops/common/util/JwtTokenUtil.java
...arwhale/mlops/exception/SwValidationException.java
...ops/storage/aliyun/StorageAccessServiceAliyun.java
...starwhale/mlops/domain/job/BaseImageConverter.java
...ale/mlops/schedule/k8s/ContainerOverwriteSpec.java
...n/java/ai/starwhale/mlops/api/TrashController.java
... and 270 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit f87cd3d into star-whale:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants