Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(log):add more visible log and status for evaluation #1826

Merged
merged 13 commits into from
Feb 22, 2023

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Feb 13, 2023

Description

  1. add more visible flags for log on the client
  2. add more statuses for task on the server(closes pod ImagePullBackOff but task status is still running #1775 )

Modules

  • UI
  • Controller
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added chore 🛎️ some tiny change e2e labels Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1826 (83adfde) into main (b2e0af5) will decrease coverage by 0.04%.
The diff coverage is 55.26%.

@@             Coverage Diff              @@
##               main    #1826      +/-   ##
============================================
- Coverage     82.65%   82.62%   -0.04%     
- Complexity     2017     2018       +1     
============================================
  Files           373      372       -1     
  Lines         19978    20013      +35     
  Branches       1070     1077       +7     
============================================
+ Hits          16513    16535      +22     
- Misses         2999     3006       +7     
- Partials        466      472       +6     
Flag Coverage Δ
controller 73.90% <51.47%> (-0.11%) ⬇️
standalone 90.79% <87.50%> (+0.05%) ⬆️
unittests 90.79% <87.50%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/ai/starwhale/mlops/api/protocol/task/TaskVo.java 0.00% <0.00%> (ø)
...n/java/ai/starwhale/mlops/domain/task/bo/Task.java 61.53% <0.00%> (-11.19%) ⬇️
...rwhale/mlops/domain/task/status/WatchableTask.java 70.45% <0.00%> (-12.48%) ⬇️
...hale/mlops/reporting/SimpleTaskStatusReceiver.java 65.00% <25.00%> (-27.86%) ⬇️
...ale/mlops/domain/task/converter/TaskConverter.java 55.55% <50.00%> (-0.70%) ⬇️
.../starwhale/mlops/schedule/k8s/JobEventHandler.java 68.75% <53.84%> (-3.48%) ⬇️
.../starwhale/mlops/schedule/k8s/PodEventHandler.java 61.53% <63.15%> (+2.91%) ⬆️
client/starwhale/core/model/model.py 87.74% <75.00%> (+0.03%) ⬆️
client/starwhale/core/model/default_handler.py 93.75% <100.00%> (+0.64%) ⬆️
...e/mlops/domain/task/converter/TaskBoConverter.java 94.11% <100.00%> (+0.36%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@goldenxinxing goldenxinxing changed the title chore(log):add more log for evaluation chore(log):add more log and status for evaluation Feb 15, 2023
@goldenxinxing goldenxinxing changed the title chore(log):add more log and status for evaluation chore(log):add more visible log and status for evaluation Feb 15, 2023
@goldenxinxing goldenxinxing self-assigned this Feb 15, 2023
@tianweidut tianweidut requested review from anda-ren, tianweidut and jialeicui and removed request for anda-ren and tianweidut February 15, 2023 09:24
@tianweidut
Copy link
Member

LGTM

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit 6b9a659 into star-whale:main Feb 22, 2023
@goldenxinxing goldenxinxing deleted the chore/simplify_log_print branch May 6, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pod ImagePullBackOff but task status is still running
3 participants