Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(install) tune helm charts for minikube mode #1823

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Feb 10, 2023

Description

  • refactor:
    • use self minio and mysql only for minikube mode
    • simplify the helm install command without storageclass
    • use override values.yaml for minikube and different network region
    • remove useless nexus charts
  • vs:
    • old helm command:
      export SWNAME=starwhale SWNS=starwhale
      helm upgrade --install $SWNAME ./ --namespace $SWNS --create-namespace --set minikube.enabled=true --set mysql.primary.persistence.storageClass=$SWNAME-mysql --set minio.persistence.storageClass=$SWNAME-minio --set image.registry=docker-registry.starwhale.cn --set minio.global.imageRegistry=docker-registry.starwhale.cn --set mysql.global.imageRegistry=docker-registry.starwhale.cn
      
    • new helm command:
      helm upgrade --install starwhale ./ -n starwhale --create-namespace -f values.minikube.cn.yaml  
      

asciicast

Modules

  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut force-pushed the enhance/minikube-helm branch 2 times, most recently from f033f88 to ef47ea2 Compare February 13, 2023 12:50
@tianweidut tianweidut changed the title WIP: enhance(install) tune helm charts for minikube enhance(install) tune helm charts for minikube Feb 13, 2023
@tianweidut tianweidut marked this pull request as ready for review February 13, 2023 13:01
@tianweidut tianweidut self-assigned this Feb 13, 2023
@tianweidut tianweidut added enhancement ❤️ New feature or request refactor 🐛 refactor code install labels Feb 13, 2023
@tianweidut tianweidut added this to the v0.3.7 milestone Feb 13, 2023
@tianweidut tianweidut changed the title enhance(install) tune helm charts for minikube enhance(install) tune helm charts for minikube mode Feb 13, 2023
@tianweidut tianweidut marked this pull request as draft February 13, 2023 13:03
@tianweidut tianweidut force-pushed the enhance/minikube-helm branch 4 times, most recently from 9d0e275 to 3d17c04 Compare February 14, 2023 11:26
@tianweidut tianweidut marked this pull request as ready for review February 14, 2023 11:27
@tianweidut tianweidut added the e2e label Feb 15, 2023
@tianweidut tianweidut marked this pull request as draft February 15, 2023 04:38
@tianweidut tianweidut marked this pull request as ready for review February 15, 2023 09:15
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit bc56cd1 into star-whale:main Feb 16, 2023
@tianweidut tianweidut deleted the enhance/minikube-helm branch February 16, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e enhancement ❤️ New feature or request install refactor 🐛 refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants