Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(controller): modify image resolve behavior #1818

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

anda-ren
Copy link
Member

Description

fix bug introduced by #1817
image
image
image
image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren self-assigned this Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #1818 (755236d) into main (c35baaf) will decrease coverage by 8.23%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main    #1818      +/-   ##
============================================
- Coverage     82.08%   73.86%   -8.23%     
  Complexity     1967     1967              
============================================
  Files           359      280      -79     
  Lines         19030     9450    -9580     
  Branches       1042     1042              
============================================
- Hits          15621     6980    -8641     
+ Misses         2971     2033     -938     
+ Partials        438      437       -1     
Flag Coverage Δ
controller 73.86% <66.66%> (+0.02%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/ai/starwhale/mlops/common/DockerImage.java 83.33% <66.66%> (ø)
client/starwhale/api/_impl/data_store.py
client/starwhale/base/mixin.py
client/starwhale/api/_impl/service.py
client/starwhale/utils/fs.py
client/starwhale/core/dataset/copy.py
client/starwhale/core/instance/view.py
client/starwhale/core/dataset/store.py
client/starwhale/base/view.py
client/starwhale/core/model/copy.py
... and 71 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 5b260cd into star-whale:main Feb 10, 2023
@tianweidut tianweidut changed the title (fix): modify image resolve behavior bug(controller): modify image resolve behavior Feb 14, 2023
@anda-ren anda-ren deleted the fix_registry branch April 10, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants