fix(controller): remove headers from model download api #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1797 +/- ##
============================================
- Coverage 82.14% 82.13% -0.02%
+ Complexity 1967 1966 -1
============================================
Files 355 355
Lines 18989 18989
Branches 1037 1038 +1
============================================
- Hits 15599 15596 -3
- Misses 2957 2958 +1
- Partials 433 435 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
goldenxinxing
force-pushed
the
fix/model_pull_file_api_more_restful
branch
from
9f9d256
to
5ef40d3
Compare
goldenxinxing
force-pushed
the
fix/model_pull_file_api_more_restful
branch
from
5ef40d3
to
830d942
Compare
|
Should the upload interface match the download? |
goldenxinxing
force-pushed
the
fix/model_pull_file_api_more_restful
branch
from
830d942
to
d4b8354
Compare
goldenxinxing
force-pushed
the
fix/model_pull_file_api_more_restful
branch
2 times, most recently
from
81bd022
to
815a754
Compare
done |
anda-ren
reviewed
Feb 8, 2023
server/controller/src/main/java/ai/starwhale/mlops/api/DatasetApi.java
Outdated
Show resolved
Hide resolved
server/controller/src/main/java/ai/starwhale/mlops/domain/model/mapper/ModelVersionMapper.java
Outdated
Show resolved
Hide resolved
goldenxinxing
force-pushed
the
fix/model_pull_file_api_more_restful
branch
3 times, most recently
from
4cd2a74
to
f58ae51
Compare
goldenxinxing
force-pushed
the
fix/model_pull_file_api_more_restful
branch
from
f58ae51
to
83bc016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unified the upload/download api for model and dataset:
changed param from 'part_name' to 'partName'
changed headers from
'X-SW-DOWNLOAD-TYPE','X-SW-DOWNLOAD-OBJECT-NAME','X-SW-DOWNLOAD-OBJECT-PATH','X-SW-DOWNLOAD-OBJECT-HASH'to'desc','partName','path','signature'and the type from header to param.Modules
Checklist