Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataset): fix user local fs data can't be fetched by server instance #1793

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Feb 7, 2023

Description

when BaseArtifact.fp is user local file path , it is unreliable and should be removed.

  • remove BaseArtifact.fp after being built by dataset if it is user local file path
    image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added the bug 🐛 Something isn't working label Feb 7, 2023
@anda-ren anda-ren self-assigned this Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #1793 (fcdf459) into main (6e5e6e3) will increase coverage by 8.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1793      +/-   ##
============================================
+ Coverage     82.14%   90.15%   +8.00%     
============================================
  Files           354       79     -275     
  Lines         18968     9572    -9396     
  Branches       1037        0    -1037     
============================================
- Hits          15582     8630    -6952     
+ Misses         2953      942    -2011     
+ Partials        433        0     -433     
Flag Coverage Δ
controller ?
standalone 90.15% <100.00%> (+0.02%) ⬆️
unittests 90.15% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/dataset/builder.py 96.21% <100.00%> (+0.01%) ⬆️
...whale/mlops/api/protocol/model/ModelVersionVo.java
...c/main/java/ai/starwhale/mlops/common/KeyLock.java
...in/java/ai/starwhale/mlops/common/IdConverter.java
...n/java/ai/starwhale/mlops/common/util/TagUtil.java
.../starwhale/mlops/schedule/k8s/JobEventHandler.java
...starwhale/mlops/domain/system/agent/bo/Device.java
...ain/java/ai/starwhale/mlops/common/BaseEntity.java
...le/mlops/domain/job/mapper/ModelServingMapper.java
...lops/domain/job/step/status/StepStatusMachine.java
... and 267 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 3cb5d64 into star-whale:main Feb 7, 2023
@anda-ren anda-ren deleted the sw_e2e_run branch February 8, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants