Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller):step entity without name #1787

Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Feb 6, 2023

Description

closes #1785

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Feb 6, 2023
@goldenxinxing goldenxinxing self-assigned this Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1787 (1546c80) into main (6e5e6e3) will decrease coverage by 8.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1787      +/-   ##
============================================
- Coverage     82.14%   74.01%   -8.14%     
+ Complexity     1962     1961       -1     
============================================
  Files           354      275      -79     
  Lines         18968     9397    -9571     
  Branches       1037     1037              
============================================
- Hits          15582     6955    -8627     
+ Misses         2953     2009     -944     
  Partials        433      433              
Flag Coverage Δ
controller 74.01% <ø> (ø)
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/ai/starwhale/mlops/datastore/DataStore.java 87.54% <0.00%> (ø)
client/starwhale/api/_impl/job.py
client/starwhale/utils/cli.py
client/starwhale/consts/__init__.py
client/starwhale/core/eval/view.py
client/starwhale/core/dataset/view.py
client/starwhale/utils/load.py
client/starwhale/utils/flatten.py
client/starwhale/utils/retry.py
client/starwhale/core/dataset/tabular.py
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dreamlandliu dreamlandliu merged commit 5708997 into star-whale:main Feb 6, 2023
@goldenxinxing goldenxinxing deleted the fix/step_entity_without_name_2 branch April 27, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tasks run with wrong num on the cloud
3 participants