Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example(dataset): add kitti lane dataset #1778

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Feb 6, 2023

Description

  • add kitti lane dataset
  • fix self.resp.raw.read() can't read whole file
    image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1778 (656db85) into main (6e5e6e3) will increase coverage by 8.04%.
The diff coverage is 85.71%.

❗ Current head 656db85 differs from pull request most recent head 4d39610. Consider uploading reports for the commit 4d39610 to get more accurate results

@@             Coverage Diff              @@
##               main    #1778      +/-   ##
============================================
+ Coverage     82.14%   90.19%   +8.04%     
============================================
  Files           354       79     -275     
  Lines         18968     9576    -9392     
  Branches       1037        0    -1037     
============================================
- Hits          15582     8637    -6945     
+ Misses         2953      939    -2014     
+ Partials        433        0     -433     
Flag Coverage Δ
controller ?
standalone 90.19% <85.71%> (+0.05%) ⬆️
unittests 90.19% <85.71%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/dataset/type.py 94.69% <83.33%> (-0.17%) ⬇️
client/starwhale/core/dataset/store.py 95.37% <100.00%> (ø)
client/starwhale/api/_impl/model.py 88.09% <0.00%> (-0.08%) ⬇️
client/starwhale/version.py 100.00% <0.00%> (ø)
client/starwhale/base/view.py 83.50% <0.00%> (ø)
client/starwhale/api/_impl/dataset/model.py 99.76% <0.00%> (ø)
...in/java/ai/starwhale/mlops/domain/trash/Trash.java
.../java/ai/starwhale/mlops/datastore/ColumnType.java
...n/java/ai/starwhale/mlops/api/ModelController.java
...a/ai/starwhale/mlops/api/EvaluationController.java
... and 278 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anda-ren anda-ren marked this pull request as draft February 6, 2023 10:04
@anda-ren anda-ren marked this pull request as ready for review February 7, 2023 09:09
@tianweidut tianweidut changed the title (dataset): add kitti lane dataset example(dataset): add kitti lane dataset Feb 8, 2023
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit ab34483 into star-whale:main Feb 15, 2023
@anda-ren anda-ren deleted the kitti-lane-main branch April 10, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants