Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client):unified the dataset table name when copy #1772

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Feb 3, 2023

Description

closes #1731

  1. origin copy:
    image
  2. changed:
    image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added e2e bug 🐛 Something isn't working labels Feb 3, 2023
@goldenxinxing goldenxinxing self-assigned this Feb 6, 2023
@goldenxinxing goldenxinxing force-pushed the fix/convert_id_to_name_when_dataset_copy branch from cd37d5a to bac3372 Compare February 6, 2023 03:27
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1772 (84a5d5c) into main (839e47b) will increase coverage by 7.94%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1772      +/-   ##
============================================
+ Coverage     82.24%   90.18%   +7.94%     
============================================
  Files           354       79     -275     
  Lines         19010     9576    -9434     
  Branches       1033        0    -1033     
============================================
- Hits          15634     8636    -6998     
+ Misses         2949      940    -2009     
+ Partials        427        0     -427     
Flag Coverage Δ
controller ?
standalone 90.18% <100.00%> (-0.02%) ⬇️
unittests 90.18% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/base/bundle_copy.py 97.60% <100.00%> (+0.02%) ⬆️
client/starwhale/core/dataset/copy.py 96.77% <100.00%> (+0.16%) ⬆️
client/starwhale/utils/http.py 81.08% <0.00%> (-5.41%) ⬇️
client/starwhale/api/_impl/dataset/builder.py 96.20% <0.00%> (-0.90%) ⬇️
client/starwhale/core/dataset/view.py 60.54% <0.00%> (-0.79%) ⬇️
client/starwhale/core/dataset/model.py 96.50% <0.00%> (-0.44%) ⬇️
client/starwhale/api/_impl/data_store.py 95.34% <0.00%> (-0.12%) ⬇️
client/starwhale/core/dataset/tabular.py 98.36% <0.00%> (ø)
...lient/starwhale/integrations/tensorflow/dataset.py 84.61% <0.00%> (ø)
...a/ai/starwhale/mlops/api/EvaluationController.java
... and 282 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@goldenxinxing goldenxinxing force-pushed the fix/convert_id_to_name_when_dataset_copy branch 3 times, most recently from 66a4ea7 to cec98af Compare February 6, 2023 06:08
@tianweidut
Copy link
Member

@goldenxinxing

  1. use another meaningful tile for this pr?
  2. should we consider model/runtime copy the same issue?

@goldenxinxing goldenxinxing changed the title fix(client):dataset copy error fix(client):unified the dataset table name when copy Feb 7, 2023
@goldenxinxing goldenxinxing force-pushed the fix/convert_id_to_name_when_dataset_copy branch 2 times, most recently from 74d238f to 34ddcf0 Compare February 7, 2023 03:28
@goldenxinxing
Copy link
Contributor Author

@goldenxinxing

  1. use another meaningful tile for this pr?
  2. should we consider model/runtime copy the same issue?

Copy model and runtime doesn't have this problem, this error only occur on dataset copy. #1731

@goldenxinxing goldenxinxing force-pushed the fix/convert_id_to_name_when_dataset_copy branch from 34ddcf0 to 84a5d5c Compare February 7, 2023 03:36
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 73c1397 into star-whale:main Feb 7, 2023
@goldenxinxing goldenxinxing deleted the fix/convert_id_to_name_when_dataset_copy branch April 27, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unified the dataset table name when copy
2 participants