Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize(console): normalize most of basic components and moved to starwhale/ui #1767

Merged
merged 15 commits into from
Feb 3, 2023
Merged

optimize(console): normalize most of basic components and moved to starwhale/ui #1767

merged 15 commits into from
Feb 3, 2023

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Feb 2, 2023

Description

  1. normalize most of basic components and moved to starwhale/ui, like button/radio/select etc
  2. fix most ui problems desc in here (https://f6phcmp2oz.feishu.cn/wiki/wikcng9EgkfPg3V5QWU663S1wrf)
  3. test storybook (wip)

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz added enhancement ❤️ New feature or request break-change 💔 break change console 🎨 console labels Feb 2, 2023
@waynelwz waynelwz added this to the v0.3.7 milestone Feb 2, 2023
jialeicui
jialeicui approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 839e47b into star-whale:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jialeicui jialeicui jialeicui approved these changes

Assignees
No one assigned
Labels
break-change 💔 break change console 🎨 console enhancement ❤️ New feature or request
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@waynelwz @jialeicui