Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): tune gradio import to slove slow import issue #1759

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

tianweidut
Copy link
Member

Description

  • gradio import will slow the starwhale package import speed.
  • for example: swcli --help command do nothing, but it will cost 3~8s because of radio.
    • before: 4s
      • image
    • after: 0.9s
      • image

Modules

  • Client
  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut self-assigned this Jan 30, 2023
@tianweidut tianweidut added this to the v0.3.7 milestone Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #1759 (306fb2c) into main (93a2cb9) will increase coverage by 7.90%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##               main    #1759      +/-   ##
============================================
+ Coverage     82.28%   90.19%   +7.90%     
============================================
  Files           352       79     -273     
  Lines         18972     9642    -9330     
  Branches       1030        0    -1030     
============================================
- Hits          15612     8697    -6915     
+ Misses         2932      945    -1987     
+ Partials        428        0     -428     
Flag Coverage Δ
controller ?
standalone 90.19% <71.42%> (-0.02%) ⬇️
unittests 90.19% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/service.py 91.56% <71.42%> (-2.19%) ⬇️
...arwhale/mlops/api/protocol/upload/UploadPhase.java
.../configuration/security/SecurityConfiguration.java
.../starwhale/mlops/exception/StarwhaleException.java
...hale/mlops/domain/system/agent/AgentConverter.java
...n/dataset/converter/DatasetVersionVoConverter.java
...n/dataset/dataloader/mapper/DataReadLogMapper.java
...a/ai/starwhale/mlops/api/protocol/user/RoleVo.java
...starwhale/mlops/domain/job/step/StepConverter.java
.../mlops/domain/model/mapper/ModelVersionMapper.java
... and 264 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 040ea8f into star-whale:main Jan 31, 2023
@tianweidut tianweidut deleted the chore/shadow-import branch April 16, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants