Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): fix console building issue #1707

Merged
merged 4 commits into from
Jan 11, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Jan 11, 2023

Description

  • add build-all cmd in console Makefile
  • fix gradio building
  • change yarn build to make build-all in pub.sh for e2e building

http://e2e-20230111.pre.intra.starwhale.ai/

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #1707 (2f101e1) into main (98f577b) will increase coverage by 7.92%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1707      +/-   ##
============================================
+ Coverage     82.29%   90.21%   +7.92%     
============================================
  Files           351       79     -272     
  Lines         18940     9629    -9311     
  Branches       1025        0    -1025     
============================================
- Hits          15586     8687    -6899     
+ Misses         2929      942    -1987     
+ Partials        425        0     -425     
Flag Coverage Δ
controller ?
standalone 90.21% <ø> (+0.02%) ⬆️
unittests 90.21% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/mlops/datastore/exporter/RecordsExporterCsv.java
...n/java/ai/starwhale/mlops/domain/user/bo/Role.java
...starwhale/mlops/domain/dataset/DatasetService.java
...arwhale/mlops/domain/system/agent/AgentStatus.java
...le/mlops/domain/job/mapper/ModelServingMapper.java
...starwhale/mlops/schedule/k8s/NodeEventHandler.java
...n/java/ai/starwhale/mlops/domain/task/bo/Task.java
...java/ai/starwhale/mlops/domain/dag/DagQuerier.java
...n/task/status/watchers/TaskWatcherForSchedule.java
...va/ai/starwhale/mlops/storage/util/MetaHelper.java
... and 263 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jialeicui jialeicui marked this pull request as ready for review January 11, 2023 09:41
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit fa90474 into star-whale:main Jan 11, 2023
@jialeicui jialeicui deleted the fix-e2e-build branch January 11, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants