Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker): support building with gradio #1701

Merged
merged 5 commits into from
Jan 10, 2023
Merged

chore(docker): support building with gradio #1701

merged 5 commits into from
Jan 10, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Jan 9, 2023 •
edited
Loading

Description

  • add building cmd in Makefile
  • remove generated assets of gradio
  • fix ci lint issues

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

waynelwz
waynelwz reviewed Jan 9, 2023
View reviewed changes
Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we inform others, make sure they run build-gradio-ui before they do fe development

@jialeicui
Copy link
Contributor Author

Should we inform others, make sure they run build-gradio-ui before they do fe development

  • Add rebuild-gradio cmd in Makefile in 5f5b2ac
  • Update readme in e372f58

@waynelwz

tianweidut
tianweidut approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tianweidut tianweidut merged commit 98f577b into star-whale:main Jan 10, 2023
@jialeicui jialeicui deleted the build-with-gradio-ui branch January 10, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianweidut tianweidut tianweidut approved these changes

@waynelwz waynelwz Awaiting requested review from waynelwz

Assignees
No one assigned
Labels
chore 🛎️ some tiny change docker 🗃️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jialeicui @tianweidut @waynelwz