Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): application configuration use snake case #1697

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Jan 6, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #1697 (e979122) into main (9c28447) will decrease coverage by 8.23%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1697      +/-   ##
============================================
- Coverage     82.31%   74.08%   -8.24%     
- Complexity     1931     1932       +1     
============================================
  Files           351      272      -79     
  Lines         18799     9175    -9624     
  Branches       1005     1005              
============================================
- Hits          15475     6797    -8678     
+ Misses         2910     1964     -946     
  Partials        414      414              
Flag Coverage Δ
controller 74.08% <100.00%> (+0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/ai/starwhale/mlops/api/DataStoreController.java 85.05% <ø> (ø)
...java/ai/starwhale/mlops/api/DatasetController.java 80.95% <ø> (ø)
...ain/java/ai/starwhale/mlops/api/EnvController.java 100.00% <ø> (ø)
...a/ai/starwhale/mlops/api/EvaluationController.java 100.00% <ø> (ø)
...ain/java/ai/starwhale/mlops/api/JobController.java 98.33% <ø> (ø)
...ain/java/ai/starwhale/mlops/api/LogController.java 100.00% <ø> (ø)
...n/java/ai/starwhale/mlops/api/ModelController.java 90.62% <ø> (ø)
...n/java/ai/starwhale/mlops/api/PanelController.java 100.00% <ø> (ø)
...java/ai/starwhale/mlops/api/ProjectController.java 86.44% <ø> (ø)
...java/ai/starwhale/mlops/api/RuntimeController.java 94.73% <ø> (ø)
... and 89 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 0c824a6 into star-whale:main Jan 9, 2023
@jialeicui jialeicui deleted the fix-config branch January 9, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants