Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): online eval support gc #1695

Merged
merged 5 commits into from
Jan 9, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Jan 4, 2023

Description

Online eval support garbage collection

  • removes the workloads that reached the max TTL
  • removes the oldest workload when there are pending workloads
    • prevent removing the workloads that not reached the min TTL

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui marked this pull request as draft January 4, 2023 11:27
@jialeicui jialeicui force-pushed the serving-gc branch 2 times, most recently from c6b28c4 to 5d8c8bc Compare January 5, 2023 07:32
@jialeicui jialeicui force-pushed the serving-gc branch 3 times, most recently from f0a9296 to 07019dc Compare January 5, 2023 08:53
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #1695 (8f65c60) into main (63fd2ef) will decrease coverage by 8.19%.
The diff coverage is 75.51%.

@@             Coverage Diff              @@
##               main    #1695      +/-   ##
============================================
- Coverage     82.32%   74.12%   -8.20%     
- Complexity     1932     1952      +20     
============================================
  Files           351      272      -79     
  Lines         18801     9311    -9490     
  Branches       1005     1025      +20     
============================================
- Hits          15478     6902    -8576     
+ Misses         2909     1985     -924     
- Partials        414      424      +10     
Flag Coverage Δ
controller 74.12% <75.51%> (+0.04%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ale/mlops/schedule/k8s/ContainerOverwriteSpec.java 100.00% <ø> (ø)
...ava/ai/starwhale/mlops/schedule/k8s/K8sClient.java 67.53% <66.66%> (+2.25%) ⬆️
...tarwhale/mlops/domain/job/ModelServingService.java 76.16% <70.43%> (-7.37%) ⬇️
...n/java/ai/starwhale/mlops/common/ProxyServlet.java 66.66% <100.00%> (+0.56%) ⬆️
...le/mlops/domain/job/mapper/ModelServingMapper.java 100.00% <100.00%> (ø)
...i/starwhale/mlops/schedule/k8s/K8sJobTemplate.java 88.88% <100.00%> (+1.38%) ⬆️
...in/java/ai/starwhale/mlops/common/TarFileUtil.java 44.57% <0.00%> (-1.21%) ⬇️
client/starwhale/api/_impl/service.py
client/starwhale/utils/cli.py
client/starwhale/base/view.py
... and 79 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jialeicui jialeicui force-pushed the serving-gc branch 4 times, most recently from 4d19182 to 9d78354 Compare January 5, 2023 11:18
@jialeicui jialeicui marked this pull request as ready for review January 5, 2023 11:26
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 6f01d9a into star-whale:main Jan 9, 2023
@jialeicui jialeicui deleted the serving-gc branch January 11, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants