Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): hijack submit on premises #1690

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Jan 3, 2023

Description

Call outer wait() function when on premises for waiting backend service to ready and getting the predicted result.
cc @waynelwz

gradio doc ref: https://www.gradio.app/custom_CSS_and_JS/

local dev mode has no effect

local.dev.mp4

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #1690 (cd905d9) into main (cf594ad) will increase coverage by 0.01%.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##               main    #1690      +/-   ##
============================================
+ Coverage     83.08%   83.10%   +0.01%     
+ Complexity     1927     1926       -1     
============================================
  Files           349      349              
  Lines         18350    18372      +22     
  Branches        974      974              
============================================
+ Hits          15247    15268      +21     
- Misses         2699     2700       +1     
  Partials        404      404              
Flag Coverage Δ
controller 75.36% <100.00%> (-0.02%) ⬇️
standalone 90.25% <89.65%> (+0.02%) ⬆️
unittests 90.25% <89.65%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/model/model.py 86.72% <0.00%> (ø)
client/starwhale/api/_impl/service.py 94.52% <92.85%> (+2.36%) ⬆️
...tarwhale/mlops/domain/job/ModelServingService.java 89.61% <100.00%> (ø)
...in/java/ai/starwhale/mlops/common/TarFileUtil.java 44.57% <0.00%> (-1.21%) ⬇️
client/starwhale/utils/venv.py 84.53% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 5edf934 into star-whale:main Jan 4, 2023
@jialeicui jialeicui deleted the gradio-config branch January 4, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants