Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): optimize model build when no model serving api #1689

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #1689 (0970343) into main (95a713f) will increase coverage by 7.14%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1689      +/-   ##
============================================
+ Coverage     83.08%   90.22%   +7.14%     
============================================
  Files           349       79     -270     
  Lines         18348     9528    -8820     
  Branches        974        0     -974     
============================================
- Hits          15245     8597    -6648     
+ Misses         2699      931    -1768     
+ Partials        404        0     -404     
Flag Coverage Δ
controller ?
standalone 90.22% <100.00%> (+<0.01%) ⬆️
unittests 90.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/service.py 92.15% <100.00%> (+0.32%) ⬆️
...a/ai/starwhale/mlops/api/protocol/user/UserVo.java
...autofit/fs/CompatibleStorageAccessServiceFile.java
.../starwhale/mlops/exception/SwProcessException.java
...le/mlops/domain/task/status/TaskStatusMachine.java
...ain/java/ai/starwhale/mlops/domain/job/bo/Job.java
...starwhale/mlops/api/protocol/storage/FileDesc.java
...ataset/upload/DatasetVersionWithMetaConverter.java
...le/mlops/domain/bundle/remove/RemoveException.java
...mlops/domain/model/converter/ModelVoConverter.java
... and 261 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit cf594ad into star-whale:main Jan 3, 2023
@jialeicui jialeicui deleted the optimize-mp-build branch January 3, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants