Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): runtime restore use enable_pre=false by default #1688

Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Jan 3, 2023

Description

avoid install pre_version when restore

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing changed the title fix(client): runtime restore use enable_pre=false by dafault fix(client): runtime restore use enable_pre=false by default Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #1688 (9267dcd) into main (95a713f) will increase coverage by 7.13%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1688      +/-   ##
============================================
+ Coverage     83.08%   90.22%   +7.13%     
============================================
  Files           349       79     -270     
  Lines         18348     9526    -8822     
  Branches        974        0     -974     
============================================
- Hits          15245     8595    -6650     
+ Misses         2699      931    -1768     
+ Partials        404        0     -404     
Flag Coverage Δ
controller ?
standalone 90.22% <100.00%> (ø)
unittests 90.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/utils/venv.py 84.53% <100.00%> (ø)
...hale/mlops/domain/bundle/remove/RemoveManager.java
...configuration/security/JwtLoginFailureHandler.java
...tofit/s3/CompatibleStorageAccessServiceS3Like.java
...e/mlops/configuration/security/JwtLoginFilter.java
...java/ai/starwhale/mlops/api/ProjectController.java
...starwhale/mlops/domain/bundle/BundleException.java
...ava/ai/starwhale/mlops/reporting/ReportedTask.java
...java/ai/starwhale/mlops/domain/model/ModelDao.java
...tarwhale/mlops/datastore/parquet/SwOutputFile.java
... and 261 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit c1d85ab into star-whale:main Jan 3, 2023
@goldenxinxing goldenxinxing deleted the fix/e2e_error_when_use_pre branch April 27, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants