Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): return 502 instead of 500 when online eval service is unavailable #1681

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Dec 29, 2022

Description

curl -i http://jialei.pre.intra.starwhale.ai/gateway/model-serving/21/
HTTP/1.1 502
Date: Thu, 29 Dec 2022 08:52:10 GMT
Content-Length: 0
Connection: keep-alive

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #1681 (f6c0a66) into main (ed979e8) will decrease coverage by 7.64%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##               main    #1681      +/-   ##
============================================
- Coverage     82.99%   75.34%   -7.65%     
- Complexity     1922     1923       +1     
============================================
  Files           350      270      -80     
  Lines         18456     8801    -9655     
  Branches        969      969              
============================================
- Hits          15317     6631    -8686     
+ Misses         2735     1767     -968     
+ Partials        404      403       -1     
Flag Coverage Δ
controller 75.34% <60.00%> (+0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/ai/starwhale/mlops/common/ProxyServlet.java 67.85% <60.00%> (-1.96%) ⬇️
client/starwhale/core/dataset/tabular.py
client/starwhale/utils/fs.py
client/starwhale/core/model/default_handler.py
client/starwhale/base/bundle_copy.py
client/starwhale/core/model/copy.py
client/starwhale/base/cloud.py
client/starwhale/api/_impl/job.py
client/starwhale/api/_impl/wrapper.py
client/starwhale/api/_impl/dataset/builder.py
... and 73 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit 09431a2 into star-whale:main Dec 29, 2022
@jialeicui jialeicui deleted the get-status branch December 29, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants