Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): support base uri for serving behind controller gateway #1659

Merged
merged 1 commit into from
Dec 26, 2022

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Dec 23, 2022

Description

Make swagger ui works well behind the controller

demo:

http://jialei.pre.intra.starwhale.ai/gateway/model-serving/23/doc

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #1659 (3fe82a0) into main (55f8e99) will increase coverage by 4.30%.
The diff coverage is 85.71%.

❗ Current head 3fe82a0 differs from pull request most recent head 98ea814. Consider uploading reports for the commit 98ea814 to get more accurate results

@@             Coverage Diff              @@
##               main    #1659      +/-   ##
============================================
+ Coverage     80.49%   84.80%   +4.30%     
============================================
  Files           362       92     -270     
  Lines         19342    10556    -8786     
  Branches        967        0     -967     
============================================
- Hits          15570     8952    -6618     
+ Misses         3369     1604    -1765     
+ Partials        403        0     -403     
Flag Coverage Δ
controller ?
standalone 84.80% <85.71%> (+<0.01%) ⬆️
unittests 84.80% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/service.py 72.38% <85.71%> (+1.07%) ⬆️
...n/java/ai/starwhale/mlops/common/ProxyServlet.java
...tarwhale/mlops/domain/job/ModelServingService.java
.../java/ai/starwhale/mlops/common/util/PageUtil.java
...ain/java/ai/starwhale/mlops/common/BaseParams.java
...ops/domain/job/mapper/JobDatasetVersionMapper.java
...whale/mlops/api/protocol/project/StatisticsVo.java
...whale/mlops/domain/panel/PanelPluginConverter.java
...rwhale/mlops/api/protocol/evaluation/ConfigVo.java
...whale/mlops/domain/job/step/status/StepStatus.java
... and 261 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 3207547 into star-whale:main Dec 26, 2022
@jialeicui jialeicui deleted the swagger-behind-gw branch December 28, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants