Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): model eval command support use-docker flag #1610

Merged
merged 9 commits into from
Dec 17, 2022

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Dec 12, 2022

Description

model eval command support use-docker flag
Tested with 4 commands(starwhale==0.3.3.dev1212202632):

  1. swcli -vvv model eval --dataset mnist/version/latest mnist/version/latest --image runtime1 --use-docker
  2. swcli -vvv model eval --dataset mnist/version/latest . --image runtime1 --use-docker
  3. swcli -vvv model eval --dataset mnist/version/latest . --runtime pytorch/version/latest --use-docker
  4. swcli -vvv model eval --dataset mnist/version/latest mnist/version/latest --runtime pytorch/version/latest --use-docker

docker file for runtime1, work dir is pytorch runtime code:

FROM 10.131.0.1:8083/starwhale:0.3.3.dev1212202632
COPY requirements-sw-lock.txt /
RUN python3 -m pip install -r /requirements-sw-lock.txt
RUN python3 -m pip install starwhale==0.3.3.dev1212202632

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added this to the v0.3.4 milestone Dec 12, 2022
@anda-ren anda-ren self-assigned this Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #1610 (e994566) into main (e07a7a6) will increase coverage by 7.03%.
The diff coverage is 79.59%.

@@             Coverage Diff              @@
##               main    #1610      +/-   ##
============================================
+ Coverage     82.66%   89.69%   +7.03%     
============================================
  Files           341       78     -263     
  Lines         17678     9267    -8411     
  Branches        931        0     -931     
============================================
- Hits          14613     8312    -6301     
+ Misses         2672      955    -1717     
+ Partials        393        0     -393     
Flag Coverage Δ
controller ?
standalone 89.69% <79.59%> (-0.05%) ⬇️
unittests 89.69% <79.59%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/model/view.py 74.00% <78.94%> (+1.06%) ⬆️
client/starwhale/utils/docker.py 71.91% <80.00%> (+3.05%) ⬆️
...i/starwhale/mlops/domain/job/status/JobStatus.java
.../protocol/dataset/upload/DatasetUploadRequest.java
...configuration/security/JwtAccessDeniedHandler.java
...in/java/ai/starwhale/mlops/common/TarFileUtil.java
...java/ai/starwhale/mlops/datastore/TableSchema.java
...hale/mlops/schedule/k8s/ResourceOverwriteSpec.java
...a/ai/starwhale/mlops/api/EvaluationController.java
...in/java/ai/starwhale/mlops/storage/StorageUri.java
... and 255 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anda-ren anda-ren marked this pull request as ready for review December 13, 2022 06:54
@tianweidut tianweidut added the feature ✨ new feature label Dec 14, 2022
@tianweidut
Copy link
Member

#1376

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 15a7468 into star-whale:main Dec 17, 2022
@anda-ren anda-ren deleted the model_use_docker2 branch January 12, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants