Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): install the correct starwhale version when startup #1607

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

jialeicui
Copy link
Contributor

Description

Part of #1603

Install the right starwhale cli before execute the real job

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #1607 (0a4bed7) into main (1f67118) will increase coverage by 7.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1607      +/-   ##
============================================
+ Coverage     82.51%   89.66%   +7.15%     
============================================
  Files           340       77     -263     
  Lines         17466     9018    -8448     
  Branches        930        0     -930     
============================================
- Hits          14412     8086    -6326     
+ Misses         2660      932    -1728     
+ Partials        394        0     -394     
Flag Coverage Δ
controller ?
standalone 89.66% <ø> (ø)
unittests 89.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../mlops/domain/model/mapper/ModelVersionMapper.java
...main/java/ai/starwhale/mlops/common/TagAction.java
...ain/java/ai/starwhale/mlops/domain/job/bo/Job.java
...i/starwhale/mlops/domain/model/po/ModelEntity.java
...io/CompatibleStorageAccessServiceBuilderMinio.java
...java/ai/starwhale/mlops/domain/job/JobService.java
...whale/mlops/api/protocol/project/StatisticsVo.java
...n/java/ai/starwhale/mlops/api/ModelController.java
...rwhale/mlops/domain/panel/PanelSettingService.java
...e/mlops/api/protocol/system/UpgradeProgressVo.java
... and 253 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit e86de94 into star-whale:main Dec 13, 2022
@jialeicui jialeicui deleted the refine-entrypoint branch December 13, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants