Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): fix dataset sdk test more stable #1580

Merged
merged 1 commit into from
Dec 4, 2022

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #1580 (ff9dbab) into main (93641cf) will increase coverage by 7.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1580      +/-   ##
============================================
+ Coverage     82.69%   89.75%   +7.06%     
============================================
  Files           333       73     -260     
  Lines         17158     8864    -8294     
  Branches        917        0     -917     
============================================
- Hits          14188     7956    -6232     
+ Misses         2581      908    -1673     
+ Partials        389        0     -389     
Flag Coverage Δ
controller ?
standalone 89.75% <100.00%> (+<0.01%) ⬆️
unittests 89.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/dataset/builder.py 96.90% <100.00%> (+0.03%) ⬆️
...tarwhale/mlops/StarwhaleControllerApplication.java
...va/ai/starwhale/mlops/common/util/Blake2bUtil.java
.../mlops/domain/model/mapper/ModelVersionMapper.java
.../mlops/storage/autofit/StorageConnectionToken.java
...java/ai/starwhale/mlops/datastore/OrderByDesc.java
...e/mlops/domain/job/status/JobStatusCalculator.java
...main/java/ai/starwhale/mlops/common/TagAction.java
...e/mlops/domain/evaluation/ViewConfigConverter.java
.../java/ai/starwhale/mlops/datastore/WalManager.java
... and 251 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit 4308466 into star-whale:main Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants