Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): refactor and fix bugs for job-dataset version #1563

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Nov 29, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu reopened this Nov 29, 2022
@dreamlandliu dreamlandliu changed the title fix(controller): fix bugs with job dataset version fix(controller): refactor and fix bugs with job dataset version Nov 29, 2022
@dreamlandliu dreamlandliu changed the title fix(controller): refactor and fix bugs with job dataset version fix(controller): refactor and fix bugs for job-dataset version Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1563 (9b6c844) into main (2576e4b) will decrease coverage by 7.04%.
The diff coverage is 71.05%.

@@             Coverage Diff              @@
##               main    #1563      +/-   ##
============================================
- Coverage     81.53%   74.48%   -7.05%     
+ Complexity     1826     1823       -3     
============================================
  Files           328      260      -68     
  Lines         16446     8267    -8179     
  Branches        909      910       +1     
============================================
- Hits          13409     6158    -7251     
+ Misses         2663     1734     -929     
- Partials        374      375       +1     
Flag Coverage Δ
controller 74.48% <71.05%> (-0.04%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/domain/dataset/converter/DatasetBoConverter.java 0.00% <0.00%> (ø)
...ps/domain/dataset/mapper/DatasetVersionMapper.java 0.00% <0.00%> (ø)
.../mlops/domain/dataset/po/DatasetVersionEntity.java 100.00% <ø> (ø)
...ataset/upload/DatasetVersionWithMetaConverter.java 81.25% <ø> (ø)
.../mlops/domain/dataset/upload/HotDatasetLoader.java 0.00% <0.00%> (ø)
.../ai/starwhale/mlops/domain/dataset/DatasetDao.java 66.00% <50.00%> (-3.24%) ⬇️
...e/mlops/domain/dataset/upload/DatasetUploader.java 77.77% <70.00%> (ø)
...java/ai/starwhale/mlops/api/DatasetController.java 80.64% <100.00%> (-0.76%) ⬇️
...starwhale/mlops/domain/dataset/DatasetService.java 83.33% <100.00%> (-1.45%) ⬇️
...rwhale/mlops/domain/dataset/bo/DatasetVersion.java 100.00% <100.00%> (ø)
... and 76 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 2119afd into star-whale:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants