Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(SDK): fix model ppl unexpected index error #1553

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

tianweidut
Copy link
Member

Description

related:

image

Modules

  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added bug 🐛 Something isn't working sdk 🐶 labels Nov 23, 2022
@tianweidut tianweidut added this to the v0.3.3 milestone Nov 23, 2022
@tianweidut tianweidut self-assigned this Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1553 (3018f98) into main (b9ed335) will increase coverage by 6.14%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##               main    #1553      +/-   ##
============================================
+ Coverage     82.44%   88.58%   +6.14%     
============================================
  Files           327       70     -257     
  Lines         16236     8192    -8044     
  Branches        859        0     -859     
============================================
- Hits          13385     7257    -6128     
+ Misses         2503      935    -1568     
+ Partials        348        0     -348     
Flag Coverage Δ
controller ?
standalone 88.58% <71.42%> (ø)
unittests 88.58% <71.42%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/model.py 90.66% <71.42%> (ø)
...e/mlops/api/protocol/system/UpgradeProgressVo.java
.../ai/starwhale/mlops/exception/SwAuthException.java
...tarwhale/mlops/api/protocol/project/ProjectVo.java
...starwhale/mlops/domain/job/step/StepConverter.java
...n/CompatibleStorageAccessServiceBuilderAliyun.java
...i/starwhale/mlops/domain/model/po/ModelEntity.java
...ai/starwhale/mlops/datastore/ColumnTypeObject.java
...io/CompatibleStorageAccessServiceBuilderMinio.java
...tarwhale/mlops/common/util/BatchOperateHelper.java
... and 248 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit b3cbc09 into star-whale:main Nov 23, 2022
@tianweidut tianweidut deleted the fix/dataset-index branch April 17, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working sdk 🐶
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants