Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(datastore): return Iterator in MemoryTable.scan #1545

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Nov 22, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1545 (f1a291d) into main (f4f4384) will decrease coverage by 6.36%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1545      +/-   ##
============================================
- Coverage     82.32%   75.96%   -6.37%     
+ Complexity     1832     1827       -5     
============================================
  Files           327      257      -70     
  Lines         16189     7993    -8196     
  Branches        855      853       -2     
============================================
- Hits          13328     6072    -7256     
+ Misses         2513     1576     -937     
+ Partials        348      345       -3     
Flag Coverage Δ
controller 75.96% <100.00%> (+0.05%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/ai/starwhale/mlops/datastore/DataStore.java 88.42% <100.00%> (+1.09%) ⬆️
...tarwhale/mlops/datastore/impl/MemoryTableImpl.java 89.10% <100.00%> (+0.47%) ⬆️
client/starwhale/base/cloud.py
client/starwhale/core/dataset/store.py
client/starwhale/core/dataset/view.py
client/starwhale/core/runtime/process.py
client/starwhale/base/uricomponents/resource.py
client/starwhale/utils/process.py
client/starwhale/api/model.py
... and 64 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit d67edda into star-whale:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants