Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example):support multiple dataset for custom example #1533

Merged

Conversation

goldenxinxing
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the chore 🛎️ some tiny change label Nov 18, 2022
@goldenxinxing goldenxinxing self-assigned this Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #1533 (62d9587) into main (4c9e8ba) will increase coverage by 6.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1533      +/-   ##
============================================
+ Coverage     82.06%   88.19%   +6.12%     
============================================
  Files           327       70     -257     
  Lines         16040     8046    -7994     
  Branches        855        0     -855     
============================================
- Hits          13164     7096    -6068     
+ Misses         2529      950    -1579     
+ Partials        347        0     -347     
Flag Coverage Δ
controller ?
standalone 88.19% <ø> (ø)
unittests 88.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ai/starwhale/mlops/domain/user/RoleConvertor.java
...n/CompatibleStorageAccessServiceBuilderAliyun.java
...arwhale/mlops/domain/user/SystemRoleConvertor.java
...java/ai/starwhale/mlops/domain/job/JobManager.java
...s/watchers/log/CancellableTaskLogK8sCollector.java
...starwhale/mlops/domain/project/ProjectService.java
...arwhale/mlops/domain/dataset/po/DatasetEntity.java
...in/java/ai/starwhale/mlops/api/UserController.java
...ale/mlops/storage/fs/StorageAccessServiceFile.java
...mlops/storage/minio/StorageAccessServiceMinio.java
... and 247 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 9105351 into star-whale:main Nov 18, 2022
@goldenxinxing goldenxinxing deleted the fix/example_support_multidataset branch April 27, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants