Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): remove tip() method from SwValidationException & SwProcessException #1481

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Nov 11, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #1481 (6894887) into main (996eb9e) will decrease coverage by 5.19%.
The diff coverage is 58.33%.

@@             Coverage Diff              @@
##               main    #1481      +/-   ##
============================================
- Coverage     81.77%   76.58%   -5.20%     
- Complexity     1813     1814       +1     
============================================
  Files           323      258      -65     
  Lines         15652     7875    -7777     
  Branches        833      833              
============================================
- Hits          12800     6031    -6769     
+ Misses         2515     1508    -1007     
+ Partials        337      336       -1     
Flag Coverage Δ
controller 76.58% <58.33%> (+0.38%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ai/starwhale/mlops/api/ObjectStoreController.java 82.75% <0.00%> (ø)
...starwhale/mlops/domain/dataset/DatasetManager.java 75.67% <0.00%> (ø)
...ps/domain/dataset/index/datastore/IndexWriter.java 86.27% <0.00%> (+1.65%) ⬆️
...mlops/domain/dataset/objectstore/DsFileGetter.java 68.96% <0.00%> (+11.82%) ⬆️
...omain/dataset/objectstore/StorageAccessParser.java 77.77% <0.00%> (+2.77%) ⬆️
...ataset/upload/DatasetVersionWithMetaConverter.java 81.25% <0.00%> (ø)
...whale/mlops/domain/job/converter/JobConvertor.java 93.54% <0.00%> (ø)
.../ai/starwhale/mlops/domain/model/ModelManager.java 75.67% <0.00%> (ø)
...starwhale/mlops/domain/runtime/RuntimeManager.java 76.31% <0.00%> (ø)
...e/mlops/domain/storage/StoragePathCoordinator.java 76.00% <0.00%> (ø)
... and 101 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xuchuan xuchuan merged commit cad9298 into star-whale:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants