-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove auth file in dataset copy process #1480
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1480 +/- ##
============================================
- Coverage 82.05% 81.82% -0.23%
- Complexity 1779 1780 +1
============================================
Files 320 322 +2
Lines 15497 15506 +9
Branches 831 834 +3
============================================
- Hits 12716 12688 -28
- Misses 2451 2483 +32
- Partials 330 335 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
server/controller/src/main/java/ai/starwhale/mlops/domain/dataset/objectstore/DsFileGetter.java
Outdated
Show resolved
Hide resolved
...r/controller/src/main/java/ai/starwhale/mlops/domain/job/split/JobSpliteratorEvaluation.java
Outdated
Show resolved
Hide resolved
LGTM |
access, secret = _key.split(":", 1) | ||
else: | ||
raise FormatError(netloc) | ||
endpoint = r.hostname or link_auth.endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint will miss the port.
In [12]: from urllib.parse import urlparse
In [13]: r= urlparse("s3://username:password@127.0.0.1:8000/bucket/key")
In [14]: r.hostname
Out[14]: '127.0.0.1'
In [16]: r.port
Out[16]: 8000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint = r.netloc.split("@")[-1] or link_auth.endpoint
Description
schema://username:password@host@bucket/path
to standered URI which isschema://username:password@host/path
authName
in apiVerification
Storage setting
Evaluations
s3
: http://uri-auto-20221110.pre.intra.starwhale.ai/projects/3/evaluations/20/resultsminio
: http://uri-auto-20221110.pre.intra.starwhale.ai/projects/3/evaluations/21/resultshttp://uri-auto-20221110.pre.intra.starwhale.ai/projects/3/evaluations/22/results
Vewers
http://uri-auto-20221110.pre.intra.starwhale.ai/projects/3/datasets/2/versions/4/files
Toggle different versions which has different types of uri inside.
Modules
Checklist