Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example): add video type & example #1473

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Nov 9, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #1473 (72f4bc3) into main (faca792) will increase coverage by 5.57%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##               main    #1473      +/-   ##
============================================
+ Coverage     81.92%   87.50%   +5.57%     
============================================
  Files           319       65     -254     
  Lines         15499     7736    -7763     
  Branches        830        0     -830     
============================================
- Hits          12698     6769    -5929     
+ Misses         2471      967    -1504     
+ Partials        330        0     -330     
Flag Coverage Δ
controller ?
standalone 87.50% <88.88%> (+<0.01%) ⬆️
unittests 87.50% <88.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/dataset/__init__.py 100.00% <ø> (ø)
client/starwhale/api/dataset.py 100.00% <ø> (ø)
client/starwhale/core/dataset/type.py 99.25% <88.88%> (-0.36%) ⬇️
...arwhale/mlops/domain/project/ProjectConvertor.java
...ai/starwhale/mlops/datastore/ColumnTypeScalar.java
.../java/ai/starwhale/mlops/api/SystemController.java
.../starwhale/mlops/domain/bundle/tag/TagManager.java
...a/ai/starwhale/mlops/api/protocol/task/TaskVo.java
...a/ai/starwhale/mlops/api/protocol/user/UserVo.java
...tarwhale/mlops/datastore/parquet/SwOutputFile.java
... and 247 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@goldenxinxing goldenxinxing force-pushed the feat/add_video_example branch 4 times, most recently from c3f73aa to 822d42a Compare November 10, 2022 11:19
@goldenxinxing goldenxinxing self-assigned this Nov 10, 2022
@goldenxinxing goldenxinxing force-pushed the feat/add_video_example branch 2 times, most recently from 19db6cc to 7094193 Compare November 11, 2022 04:39
@goldenxinxing goldenxinxing changed the title WIP feat(example): add video type & example feat(example): add video type & example Nov 11, 2022
@goldenxinxing goldenxinxing marked this pull request as ready for review November 11, 2022 05:34
@goldenxinxing goldenxinxing force-pushed the feat/add_video_example branch 4 times, most recently from 77c5624 to 2997bd2 Compare November 11, 2022 11:15
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 92c3baf into star-whale:main Nov 13, 2022
@goldenxinxing goldenxinxing deleted the feat/add_video_example branch April 27, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants