Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(datastore): add parquet read/write support for memory table #1467

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Nov 7, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #1467 (215f900) into main (e88ba85) will decrease coverage by 6.03%.
The diff coverage is 76.56%.

@@             Coverage Diff              @@
##               main    #1467      +/-   ##
============================================
- Coverage     81.82%   75.79%   -6.04%     
- Complexity     1668     1749      +81     
============================================
  Files           309      252      -57     
  Lines         14962     7626    -7336     
  Branches        741      797      +56     
============================================
- Hits          12243     5780    -6463     
+ Misses         2418     1526     -892     
- Partials        301      320      +19     
Flag Coverage Δ
controller 75.79% <76.56%> (+0.02%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../starwhale/mlops/exception/SwProcessException.java 67.85% <0.00%> (-11.31%) ⬇️
...starwhale/mlops/datastore/parquet/SwInputFile.java 43.02% <43.02%> (ø)
...lops/datastore/parquet/SwParquetWriterBuilder.java 45.83% <45.83%> (ø)
...ai/starwhale/mlops/datastore/ColumnTypeScalar.java 86.30% <77.63%> (-4.74%) ⬇️
...tarwhale/mlops/datastore/parquet/SwOutputFile.java 78.57% <78.57%> (ø)
...arwhale/mlops/datastore/parquet/SwReadSupport.java 78.94% <78.94%> (ø)
...java/ai/starwhale/mlops/datastore/TableSchema.java 91.30% <81.48%> (-4.09%) ⬇️
...a/ai/starwhale/mlops/datastore/ColumnTypeList.java 92.30% <96.42%> (+3.11%) ⬆️
...ai/starwhale/mlops/datastore/ColumnTypeObject.java 92.30% <97.14%> (+2.45%) ⬆️
.../java/ai/starwhale/mlops/datastore/WalManager.java 78.10% <97.82%> (+3.86%) ⬆️
... and 74 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuchuan xuchuan merged commit a26e9cc into star-whale:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants