Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(runtime): refactor runtime dependencies with user original sequence #1445

Merged

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Nov 1, 2022

Description

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3.1 milestone Nov 1, 2022
@tianweidut tianweidut self-assigned this Nov 1, 2022
@tianweidut tianweidut force-pushed the feat/runtime-dependencies-seq branch 4 times, most recently from cc92050 to baa3149 Compare November 2, 2022 03:53
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #1445 (3b3f462) into main (4aeaac1) will increase coverage by 6.62%.
The diff coverage is 92.79%.

@@             Coverage Diff              @@
##               main    #1445      +/-   ##
============================================
+ Coverage     80.78%   87.41%   +6.62%     
============================================
  Files           293       65     -228     
  Lines         14178     7652    -6526     
  Branches        696        0     -696     
============================================
- Hits          11454     6689    -4765     
+ Misses         2449      963    -1486     
+ Partials        275        0     -275     
Flag Coverage Δ
controller ?
standalone 87.41% <92.79%> (+0.73%) ⬆️
unittests 87.41% <92.79%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/utils/venv.py 85.02% <61.53%> (+5.80%) ⬆️
client/starwhale/core/runtime/model.py 94.57% <94.32%> (+1.41%) ⬆️
client/starwhale/base/type.py 100.00% <100.00%> (ø)
client/starwhale/utils/fs.py 78.86% <100.00%> (+1.27%) ⬆️
...ps/domain/task/status/TaskStatusChangeWatcher.java
...ain/java/ai/starwhale/mlops/common/BaseEntity.java
...n/java/ai/starwhale/mlops/datastore/DataStore.java
...va/ai/starwhale/mlops/domain/task/TaskService.java
...i/starwhale/mlops/domain/system/SystemVersion.java
...va/ai/starwhale/mlops/storage/util/MetaHelper.java
... and 225 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut force-pushed the feat/runtime-dependencies-seq branch 5 times, most recently from dffbcf2 to d574d05 Compare November 2, 2022 10:45
@tianweidut tianweidut changed the title WIP: enhance(runtime): refactor runtime dependencies with user original sequence enhance(runtime): refactor runtime dependencies with user original sequence Nov 2, 2022
@tianweidut tianweidut marked this pull request as ready for review November 2, 2022 10:46
@tianweidut tianweidut force-pushed the feat/runtime-dependencies-seq branch 4 times, most recently from 7b99218 to b9603cb Compare November 3, 2022 02:35
client/starwhale/core/runtime/model.py Outdated Show resolved Hide resolved
client/starwhale/core/runtime/model.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 3e37937 into star-whale:main Nov 3, 2022
@tianweidut tianweidut deleted the feat/runtime-dependencies-seq branch April 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starwhale Runtime supports to install pkgs/files by the dependencies field order
2 participants