Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): use sys.ver when python version not specified in runtime.yaml #1338

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Oct 10, 2022

Description

  • Use current python version (swcli) when python version not specified in runtime.yaml
  • Remove python version in pytorch runtime.yaml in example

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui marked this pull request as draft October 10, 2022 06:37
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #1338 (b25ce52) into main (e630479) will increase coverage by 8.73%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1338      +/-   ##
============================================
+ Coverage     76.82%   85.55%   +8.73%     
============================================
  Files           292       63     -229     
  Lines         13803     7215    -6588     
  Branches        700        0     -700     
============================================
- Hits          10604     6173    -4431     
+ Misses         2958     1042    -1916     
+ Partials        241        0     -241     
Flag Coverage Δ
controller ?
standalone 85.55% <100.00%> (+<0.01%) ⬆️
unittests 85.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/utils/venv.py 79.17% <ø> (ø)
client/starwhale/core/runtime/model.py 92.88% <100.00%> (+0.02%) ⬆️
...ain/java/ai/starwhale/mlops/api/protocol/Code.java
...a/ai/starwhale/mlops/common/util/JwtTokenUtil.java
...whale/mlops/domain/job/status/JobUpdateHelper.java
...n/java/ai/starwhale/mlops/domain/dag/bo/Graph.java
...arwhale/mlops/domain/system/agent/AgentStatus.java
...starwhale/mlops/domain/bundle/BundleException.java
...ain/java/ai/starwhale/mlops/api/LogController.java
...arwhale/mlops/exception/ApiOperationException.java
... and 221 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jialeicui jialeicui marked this pull request as ready for review October 10, 2022 07:37
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit b3297a4 into star-whale:main Oct 10, 2022
@jialeicui jialeicui deleted the rt-py-ver branch October 10, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants