Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e):add memory for e2e #1321

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Sep 30, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #1321 (d7f8f2f) into main (04b92d9) will increase coverage by 9.38%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1321      +/-   ##
============================================
+ Coverage     76.18%   85.56%   +9.38%     
============================================
  Files           291       63     -228     
  Lines         13771     7171    -6600     
  Branches        702        0     -702     
============================================
- Hits          10491     6136    -4355     
+ Misses         3039     1035    -2004     
+ Partials        241        0     -241     
Flag Coverage Δ
controller ?
standalone 85.56% <ø> (ø)
unittests 85.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../starwhale/mlops/exception/StarwhaleException.java
...arwhale/mlops/api/protocol/user/ProjectRoleVo.java
...ps/domain/system/resourcepool/bo/ResourcePool.java
...hale/mlops/api/protocol/swmp/SwModelPackageVo.java
...whale/mlops/storage/s3/StorageAccessServiceS3.java
...mlops/storage/minio/StorageAccessServiceMinio.java
...hale/mlops/reporting/SimpleTaskStatusReceiver.java
...ops/api/protocol/swmp/SwModelPackageVersionVo.java
...arwhale/mlops/domain/project/ProjectConvertor.java
...arwhale/mlops/exception/SwValidationException.java
... and 218 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 6f9fff3 into star-whale:main Sep 30, 2022
@goldenxinxing goldenxinxing deleted the fix/add_memory_for_e2e branch April 27, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants