Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(controller): unit test for dataset and runtime controller #1299

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Sep 23, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu self-assigned this Sep 23, 2022
@dreamlandliu dreamlandliu added this to the v0.3 milestone Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #1299 (dcf94d5) into main (643d56e) will decrease coverage by 9.44%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1299      +/-   ##
============================================
- Coverage     74.54%   65.09%   -9.45%     
- Complexity     1236     1287      +51     
============================================
  Files           288      226      -62     
  Lines         13398     6368    -7030     
  Branches        654      655       +1     
============================================
- Hits           9987     4145    -5842     
+ Misses         3188     2000    -1188     
  Partials        223      223              
Flag Coverage Δ
controller 65.09% <100.00%> (+2.90%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/ai/starwhale/mlops/api/DatasetController.java 92.03% <100.00%> (+92.03%) ⬆️
...java/ai/starwhale/mlops/api/RuntimeController.java 94.66% <100.00%> (+94.66%) ⬆️
...tarwhale/mlops/api/protocol/runtime/RuntimeVo.java 100.00% <100.00%> (ø)
...arwhale/mlops/domain/runtime/RuntimeConvertor.java 100.00% <100.00%> (+100.00%) ⬆️
client/starwhale/consts/env.py
client/starwhale/core/dataset/tabular.py
client/starwhale/version.py
client/starwhale/core/dataset/model.py
client/starwhale/api/model.py
client/starwhale/api/_impl/metric.py
... and 63 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit e371da2 into star-whale:main Sep 26, 2022
@dreamlandliu dreamlandliu deleted the ut/controller_0923 branch January 6, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants