Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(job): refactor sw-docker-entrypiont with split swmp and swrt workdir #1293

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Sep 23, 2022

Description

related: #1292

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added enhancement ❤️ New feature or request break-change 💔 break change job 💡 labels Sep 23, 2022
@tianweidut tianweidut added this to the v0.3 milestone Sep 23, 2022
@tianweidut tianweidut self-assigned this Sep 23, 2022
@tianweidut tianweidut changed the title enhance(job): refactor sw-docker-entrypiont with split swmp and swrt workdir WIP enhance(job): refactor sw-docker-entrypiont with split swmp and swrt workdir Sep 23, 2022
@tianweidut tianweidut changed the title WIP enhance(job): refactor sw-docker-entrypiont with split swmp and swrt workdir enhance(job): refactor sw-docker-entrypiont with split swmp and swrt workdir Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #1293 (490b8e9) into main (7c35873) will increase coverage by 11.15%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1293       +/-   ##
=============================================
+ Coverage     74.53%   85.68%   +11.15%     
=============================================
  Files           288       63      -225     
  Lines         13394     7043     -6351     
  Branches        653        0      -653     
=============================================
- Hits           9983     6035     -3948     
+ Misses         3188     1008     -2180     
+ Partials        223        0      -223     
Flag Coverage Δ
controller ?
standalone 85.68% <100.00%> (+<0.01%) ⬆️
unittests 85.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/eval/executor.py 91.73% <ø> (ø)
client/starwhale/base/type.py 100.00% <100.00%> (ø)
...e/mlops/configuration/security/JwtTokenFilter.java
...va/ai/starwhale/mlops/domain/bundle/BundleUrl.java
...rwhale/mlops/domain/swmp/SwmpVersionConvertor.java
...rwhale/mlops/api/protocol/runtime/BaseImageVo.java
...starwhale/mlops/domain/runtime/RuntimeService.java
...e/mlops/configuration/security/JwtLoginFilter.java
...ale/mlops/exception/api/StarwhaleApiException.java
...ava/ai/starwhale/mlops/datastore/ColumnSchema.java
... and 217 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 7f40068 into star-whale:main Sep 23, 2022
@tianweidut tianweidut deleted the enhance/sw-entrypoint branch September 23, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
break-change 💔 break change enhancement ❤️ New feature or request job 💡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants