Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datastore): support complex column types #1277

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Sep 21, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #1277 (e031614) into main (204976b) will decrease coverage by 2.01%.
The diff coverage is n/a.

❗ Current head e031614 differs from pull request most recent head 1e8e368. Consider uploading reports for the commit 1e8e368 to get more accurate results

@@             Coverage Diff              @@
##               main    #1277      +/-   ##
============================================
- Coverage     75.90%   73.88%   -2.02%     
+ Complexity     1287     1212      -75     
============================================
  Files           289      287       -2     
  Lines         13413    13399      -14     
  Branches        655      651       -4     
============================================
- Hits          10181     9900     -281     
- Misses         3009     3277     +268     
+ Partials        223      222       -1     
Flag Coverage Δ
controller 60.87% <0.00%> (-4.22%) ⬇️
standalone 85.64% <0.00%> (-0.04%) ⬇️
unittests 85.64% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/job.py 0.00% <0.00%> (-100.00%) ⬇️
client/starwhale/api/metric.py 0.00% <0.00%> (-100.00%) ⬇️
.../ai/starwhale/mlops/domain/swmp/SwmpConvertor.java 0.00% <0.00%> (-100.00%) ⬇️
...arwhale/mlops/domain/runtime/RuntimeConvertor.java 0.00% <0.00%> (-100.00%) ⬇️
...hale/mlops/api/protocol/swmp/SwModelPackageVo.java 0.00% <0.00%> (-100.00%) ⬇️
...le/mlops/api/protocol/swds/upload/UploadPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../starwhale/mlops/api/SwModelPackageController.java 0.00% <0.00%> (-95.00%) ⬇️
...java/ai/starwhale/mlops/api/RuntimeController.java 0.00% <0.00%> (-94.67%) ⬇️
...java/ai/starwhale/mlops/api/DatasetController.java 0.00% <0.00%> (-92.04%) ⬇️
.../mlops/api/protocol/swds/upload/UploadRequest.java 25.00% <0.00%> (-25.00%) ⬇️
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit e862a74 into star-whale:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants