Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add job status to evaluation summary #1273

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Sep 21, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #1273 (1a4ad58) into main (1959fe5) will decrease coverage by 12.99%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1273       +/-   ##
=============================================
- Coverage     73.86%   60.87%   -13.00%     
  Complexity     1212     1212               
=============================================
  Files           287      225       -62     
  Lines         13390     6362     -7028     
  Branches        651      651               
=============================================
- Hits           9891     3873     -6018     
+ Misses         3277     2267     -1010     
  Partials        222      222               
Flag Coverage Δ
controller 60.87% <100.00%> (+<0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ale/mlops/domain/evaluation/EvaluationService.java 76.47% <100.00%> (+0.35%) ⬆️
client/starwhale/utils/process.py
client/starwhale/utils/venv_pack.py
client/starwhale/core/dataset/model.py
client/starwhale/core/model/model.py
client/starwhale/api/job.py
client/starwhale/core/eval/model.py
client/starwhale/base/type.py
client/starwhale/mngt/__init__.py
client/starwhale/core/job/scheduler.py
... and 53 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 0819efd into star-whale:main Sep 22, 2022
@dreamlandliu dreamlandliu deleted the feat/evaluation_job_status branch January 6, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants